-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uk (Ukrainian) locale month #899
Merged
Merged
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
7c9430c
fixed monthFormat uk locale
Valerika b241d30
fixed uk locale (month variables)
Valerika fa18f07
Update uk.test.js
Valerika bf5a34e
Update customParseFormat.test.js
Valerika 589e6ea
Update customParseFormat.test.js
Valerika df3f9ae
uncomment
Valerika 8d2ab52
changed short month format
Valerika 7aef282
removed semicolon
Valerika 5ac4149
fixed test for uk locale
Valerika 985534b
fixed comparing timestamp with moment
Valerika 59b122e
Update customParseFormat.test.js
Valerika 79af078
Update customParseFormat.test.js
Valerika 0313218
Update customParseFormat.test.js
Valerika 6e96d3c
Update customParseFormat.test.js
Valerika 324363c
Update customParseFormat.test.js
Valerika fe9d4e3
fixed month format
Valerika 0814c53
fixed short format month
Valerika 0dde774
removed plugin from customParseFormat test
Valerika 71fabcd
fixed month short format
Valerika a6fdd51
fixed eslint error in uk locale
Valerika File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's no difference in
monthShort
, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, you're right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not using the original
monthsShort
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the same logic with long names
(I looked Russian locale file)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no need actually.
You can just add
monthFormat
andmonthStandalone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok