Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: --label GLOB filter #1571

Merged
merged 5 commits into from
Oct 30, 2024
Merged

feat: --label GLOB filter #1571

merged 5 commits into from
Oct 30, 2024

Conversation

ianlewis
Copy link
Owner

@ianlewis ianlewis commented Oct 30, 2024

Description:

A new --label flag is added that takes a GLOB and matches against TODO labels. The flag can be included multilpe times. A TODO that matches any label is included in the output.

Related Issues:

Fixes #1562

Checklist:

  • Review the CONTRIBUTING.md documentation.
  • Add a reference to a related issue in the repository.
  • Add a description of the changes proposed in the pull request.
  • Add unit tests if applicable.
  • Update documentation if applicable.
  • Add a note in the CHANGELOG.md if applicable.
  • Sign the Google CLA.

A new `--label` flag is added that takes a GLOB and matches against
TODO labels. The flag can be included multilpe times. A TODO that
matches any label is included in the output.

Fixes #1562

Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
@ianlewis ianlewis linked an issue Oct 30, 2024 that may be closed by this pull request
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes missing coverage. Please review.

Project coverage is 76.24%. Comparing base (865cd2b) to head (7e0273a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/cmd/todos/app.go 89.65% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1571      +/-   ##
==========================================
+ Coverage   75.94%   76.24%   +0.29%     
==========================================
  Files          17       17              
  Lines        1160     1187      +27     
==========================================
+ Hits          881      905      +24     
- Misses        203      205       +2     
- Partials       76       77       +1     
Files with missing lines Coverage Δ
internal/walker/walker.go 60.07% <100.00%> (+1.48%) ⬆️
internal/cmd/todos/app.go 82.64% <89.65%> (-0.02%) ⬇️

Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
@ianlewis ianlewis changed the title Add --label GLOB filter feat: --label GLOB filter Oct 30, 2024
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
@ianlewis ianlewis merged commit ade51a4 into main Oct 30, 2024
15 checks passed
@ianlewis ianlewis deleted the 1562-feature-filter-todos-by-label branch October 30, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] Filter TODOs by label
1 participant