Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update relative path calculation #491

Conversation

ianlewis
Copy link
Owner

@ianlewis ianlewis commented Aug 30, 2023

Description:

Updates the relative path calculation so that the issue-reopener action will work with checkouts outside the GITHUB_WORKSPACE.

Related Issues:

Fixes #262

Checklist:

  • Review the CONTRIBUTING.md documentation.
  • Add a reference to a related issue in the repository.
  • Add a description of the changes proposed in the pull request.
  • Sign the Google CLA.
  • Commits include a Developer Certificate of Origin signoff.
    This is my commit message
    Signed-off-by: Random J Developer <random@developer.example.org>
    
  • Unit tests

Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #491 (0e366a4) into main (9a7c862) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #491      +/-   ##
==========================================
+ Coverage   80.30%   80.32%   +0.01%     
==========================================
  Files          19       19              
  Lines        1097     1098       +1     
  Branches       14       14              
==========================================
+ Hits          881      882       +1     
  Misses        155      155              
  Partials       61       61              
Files Changed Coverage Δ
actions/issue-reopener/src/action.ts 90.90% <100.00%> (ø)
actions/issue-reopener/src/reopener.ts 100.00% <100.00%> (ø)

Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
@ianlewis ianlewis marked this pull request as ready for review August 30, 2023 08:02
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
Signed-off-by: Ian Lewis <ianmlewis@gmail.com>
@ianlewis ianlewis merged commit 6967be4 into main Aug 30, 2023
28 checks passed
@ianlewis ianlewis deleted the 262-issue-reopener-support-checkout-path-other-than-github_workspace branch August 30, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[issue-reopener] support checkout path other than GITHUB_WORKSPACE
1 participant