Implement Axis3d.intersectionWithRectangle #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w0rm
force-pushed
the
intersection-with-rectangle
branch
from
534ae0f to
63d87ab
Compare
w0rm
force-pushed
the
intersection-with-rectangle
branch
from
63d87ab to
470a31d
Compare
|
Rebased and added tests similar to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented intersection of a ray with rectangle. I had to inline plane construction because of circular dependency.
Any idea on how this can be tested? I can add hardcoded test cases, but I wonder if we could come up with some fuzz tests.