-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies, fix linter options and other details #47
Conversation
Thanks for the pull request. Unfortunately, the changes are failing as the package name has been renamed. Can you revert the package name change and try again? |
Hi @ianperrin 🙂 |
Understood. Will anyone who has installed the module need to update their config file to use the lowercase name? If so this is a breaking change and will need mentioning in the updating section and example corrected in the Using the module sections of the README.md Finally, sometime ago, I had created tests/node_helper.test.js with the intention of writing some tests for the module. For completeness, I believe the module name needs changing there too |
Users shouldn't even notice the change. I have corrected this in other modules without issues. But the test process still hangs: I would take a look at that in the next few days. Until then I'll put the PR on draft 🙂 |
- node 14 reaches End Of Life next month: https://endoflife.date/nodejs - the tests are only failing with node 14 - the module still works with node 14
The tests should now work 🙂 The module works with node 14, but the tests with node 14 fail. Since node 14 will be EOL next month, I thought we can omit the node 14 test 😅 |
BTW: There is no breaking change. |
Great thanks @KristjanESPERANTO |
No description provided.