Migrate testing suite to Vitest #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeoffrey
commented
Jun 2, 2024
Comment on lines
-14
to
-21
| describe('superstruct', () => { | ||
| describe('api', () => { | ||
| require('./api/assert') | ||
| require('./api/create') | ||
| require('./api/is') | ||
| require('./api/mask') | ||
| require('./api/validate') | ||
| }) |
There was a problem hiding this comment.
Since these are automatically run by changing the filename to end with .test.ts, I've removed them here.
|
Hey @yeoffrey -- this is lovely! ❤️ I agree that to make things feel more Vitest-y it should probably be organised differently. PRs on that front extremely welcome! Merging... |
5 tasks
yeoffrey
added a commit
to yeoffrey/superstruct
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1226
Description
This PR contains the changes nessessary to migrate the current testing suite, which is Mocha to Vitest. This is similar to ciscoheat's PR, except that it only contains Vitest changes.
Note: Vitest automatically finds tests by looking for filenames that end with
.test.ts, so I've done this here. This should also help unblock #1224.Next steps
I believe that the current way which the test suite gathers files from the file system is not ideal. I think theres a better way to organize these tests, but that should be in another PR.