Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of the PR is to make
object()
types withoptional()
values appear as optional properties on an object. e.g.There is also a related change to
package.json
which adds a scriptwatch:types
. The purpose of this script is so that when there are changes to code, the TypeScript type definitions get updated. During the normalwatch
, type changes are not reflected. A better solution may be to addbuild:types
as part of thewatch
script instead of in a separatewatch:types
script.Stylistically, the type helpers are near the
object
code. There aren't any existing type helpers (at least in the code I saw) so the choice to locate the type helpers near the code is arbitrary. It may be preferable to place them inutils
; however, the code isn't used anywhere else (ie. it's not shared) so I opted to put it right above theobject
code. Let me know if you prefer it elsewhere.