Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rumble extractor #1232

Merged
merged 4 commits into from
May 9, 2023
Merged

Add Rumble extractor #1232

merged 4 commits into from
May 9, 2023

Conversation

shavit
Copy link
Contributor

@shavit shavit commented May 7, 2023

Support for Rumble #1188

Copy link
Owner

@iawia002 iawia002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And you need to update README here: https://github.com/iawia002/lux#supported-sites

extractors/rumble/rumble.go Outdated Show resolved Hide resolved
@shavit shavit changed the title Add Rumble extractor [WIP] Add Rumble extractor May 8, 2023
@shavit shavit changed the title [WIP] Add Rumble extractor Add Rumble extractor May 8, 2023
Copy link
Owner

@iawia002 iawia002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants