Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extractors/netease #312

Merged
merged 2 commits into from
Nov 6, 2018
Merged

extractors/netease #312

merged 2 commits into from
Nov 6, 2018

Conversation

lishubing
Copy link
Contributor

Add extractor for netease music mv.

@lishubing
Copy link
Contributor Author

emm...facebook test seems to be broken...

@codecov
Copy link

codecov bot commented Nov 6, 2018

Codecov Report

Merging #312 into master will increase coverage by 0.07%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
+ Coverage   72.16%   72.23%   +0.07%     
==========================================
  Files          26       27       +1     
  Lines        1972     2006      +34     
==========================================
+ Hits         1423     1449      +26     
- Misses        392      396       +4     
- Partials      157      161       +4
Impacted Files Coverage Δ
extractors/netease/netease.go 76.47% <76.47%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff59275...fe62c4b. Read the comment docs.

Copy link
Owner

@iawia002 iawia002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@iawia002 iawia002 merged commit 662a05f into iawia002:master Nov 6, 2018
@joostshao
Copy link

i think we should support playlist for netease music, you know, playlist is a good agg for single data.
example: https://music.163.com/#/playlist?id=109393127

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants