Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extractors/geekbang: Renewed support #655

Merged
merged 3 commits into from
Apr 8, 2020
Merged

Conversation

weiyongsheng
Copy link
Contributor

重新对极客时间的支持

@weiyongsheng
Copy link
Contributor Author

@iawia002 请问这个怎么重新build啊?麻烦看一下,谢谢!

Copy link
Owner

@iawia002 iawia002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, a few comments

extractors/geekbang/geekbang.go Outdated Show resolved Hide resolved
extractors/geekbang/geekbang.go Outdated Show resolved Hide resolved
extractors/geekbang/geekbang.go Outdated Show resolved Hide resolved
Co-Authored-By: Xinzhao Xu <xuxinzhao@caicloud.io>
@weiyongsheng
Copy link
Contributor Author

@iawia002 Resolved.

Copy link
Owner

@iawia002 iawia002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@iawia002 iawia002 merged commit 90e4f8f into iawia002:master Apr 8, 2020
M1178475702 pushed a commit to M1178475702/annie that referenced this pull request Apr 16, 2020
* extractors/geekbang: Renewed support

* extractors/miaopai: fix request and result error

* extractors/geekbang: Update comments

Co-Authored-By: Xinzhao Xu <xuxinzhao@caicloud.io>

Co-authored-by: Yongsheng Wei <yongshengmm@gmail.com>
Co-authored-by: Xinzhao Xu <xuxinzhao@caicloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants