Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7278: Changed HTML form to symfony one #1075

Merged
merged 6 commits into from
Feb 1, 2024
Merged

IBX-7278: Changed HTML form to symfony one #1075

merged 6 commits into from
Feb 1, 2024

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Dec 22, 2023 •
edited
Loading

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-7278
Bug fix? yes
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

This adds sort of extension point to modify list of available siteaccesses like done in:
https://github.com/ibexa/corporate-account/pull/227

This needs some frontend love, hence work in progress.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@ViniTou ViniTou requested a review from a team January 8, 2024 13:19
@ViniTou ViniTou mentioned this pull request Jan 11, 2024
Merged
5 tasks
@ViniTou ViniTou force-pushed the ibx-7278-sa-list-extension-point branch from cdaa01b to 0e35a66 Compare January 16, 2024 13:25
@ViniTou ViniTou requested a review from Steveb-p January 16, 2024 13:25
@Steveb-p Steveb-p requested a review from a team January 16, 2024 13:56
@katarzynazawada katarzynazawada mentioned this pull request Jan 19, 2024
Closed
@ViniTou ViniTou force-pushed the ibx-7278-sa-list-extension-point branch from b5cde4e to 5a53f03 Compare January 19, 2024 09:38
@ViniTou ViniTou force-pushed the ibx-7278-sa-list-extension-point branch from 5a53f03 to 7cff163 Compare January 25, 2024 15:08
katarzynazawada
katarzynazawada requested changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@katarzynazawada katarzynazawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

500 error occurs when no site is selected in dropdown(All context) and then go to Preview
Screenshot 2024-01-26 at 09 20 54

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ViniTou ViniTou merged commit 5f8d467 into main Feb 1, 2024
22 checks passed
@ViniTou ViniTou deleted the ibx-7278-sa-list-extension-point branch February 1, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@webhdx webhdx webhdx approved these changes

@katarzynazawada katarzynazawada katarzynazawada approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ViniTou @Steveb-p @webhdx @katarzynazawada @mikadamczyk @Nattfarinn @ciastektk @dew326