Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7852: Exposed maxFileSize values per each image Content Type #1194

Closed
wants to merge 1 commit into from

Conversation

konradoboza
Copy link
Contributor

@konradoboza konradoboza commented Feb 28, 2024

Question Answer
JIRA issue IBX-7852
Type improvement
Target version v4.6
BC breaks no
Doc needed no

To make sue DAM gets proper file size limits, we need to iterate over image-suitable Content Types and get their configured maxFileSize values. If none was set, we fallback to the "global", YAML-configured one.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@konradoboza konradoboza requested a review from a team February 28, 2024 12:45
@mikadamczyk mikadamczyk requested a review from a team February 28, 2024 13:31
@konradoboza
Copy link
Contributor Author

Incorporated into #1184, closing.

@konradoboza konradoboza deleted the ibx-7852-expose-dam-files-upload-limit branch March 19, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants