Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7699: Empty chart state updated #1216

Merged
merged 1 commit into from
Apr 29, 2024
Merged

IBX-7699: Empty chart state updated #1216

merged 1 commit into from
Apr 29, 2024

Conversation

Gengar-i
Copy link
Contributor

Question Answer
JIRA issue IBX-7699
Type bug
Target version v4.6
BC breaks no
Doc needed no

Empty chart state updated

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

dew326
dew326 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@dew326 dew326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be targeted to 4.6

@Gengar-i Gengar-i changed the base branch from main to 4.6 April 4, 2024 10:27
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@juskora juskora mentioned this pull request Apr 26, 2024
Closed
@juskora
Copy link
Contributor

juskora commented Apr 29, 2024

QA Approved on Ibexa DXP Commerce 4.6-dev.

@mikadamczyk mikadamczyk merged commit 1de228d into 4.6 Apr 29, 2024
22 checks passed
@mikadamczyk mikadamczyk deleted the ibx-7699-empty-chart branch April 29, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@dew326 dew326 dew326 approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@juskora juskora juskora approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@dew326 dew326

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Gengar-i @juskora @mikadamczyk @GrabowskiM @dew326 @lucasOsti