IBX-1742: Dropdown not working in Shipping Management - dynamic dropdowns #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tischsoic
commented
Dec 20, 2021
tischsoic
commented
| Question | Answer |
|---|---|
| Tickets | https://issues.ibexa.co/browse/IBX-1742 |
| Bug fix? | yes/no |
| New feature? | yes/no |
| BC breaks? | yes/no |
| Tests pass? | yes |
| Doc needed? | yes/no |
| License | GPL-2.0 |
tischsoic
commented
Dec 20, 2021
| @@ -68,7 +71,7 @@ | |||
|
|
|||
| {% include '@ibexadesign/ui/component/dropdown/dropdown_selected_item.html.twig' with { | |||
| value: first_choice.value, | |||
| label: _self.get_translated_label(first_choice.label), | |||
| label: _self.get_translated_label(first_choice.label, false), | |||
There was a problem hiding this comment.
There was no translation_domain so I guess we want to pass false here (as the condition in macro is translation_domain is same as(false), which is false for not defined translation_domain)?
Can you confirm @GrabowskiM? :)
There was a problem hiding this comment.
We want to use translation_domain variable, as in all other uses of this macro (for example line 67)
lucasOsti
approved these changes
Dec 20, 2021
GrabowskiM
requested changes
Dec 20, 2021
| @@ -68,7 +71,7 @@ | |||
|
|
|||
| {% include '@ibexadesign/ui/component/dropdown/dropdown_selected_item.html.twig' with { | |||
| value: first_choice.value, | |||
| label: _self.get_translated_label(first_choice.label), | |||
| label: _self.get_translated_label(first_choice.label, false), | |||
There was a problem hiding this comment.
We want to use translation_domain variable, as in all other uses of this macro (for example line 67)
dew326
approved these changes
Dec 20, 2021
GrabowskiM
approved these changes
Dec 20, 2021
lucasOsti
approved these changes
Dec 20, 2021
dew326
approved these changes
Dec 20, 2021
GrabowskiM
approved these changes
Dec 20, 2021
tischsoic
force-pushed
the
IBX-1742-dropdown-not-working-in-shipping-management
branch
from
a760317
to
1797527
Compare
dew326
deleted the
IBX-1742-dropdown-not-working-in-shipping-management
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.