IBX-8075: User (group) re-selection not possible after failed role assignment #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tischsoic
commented
Apr 15, 2024
•
tischsoic
commented
| 🎫 Issue | IBX-8075 |
|---|
tischsoic
force-pushed
the
IBX-8075-fix-role-assignment-UDW-crash
branch
from
9a7ec2d
to
280fab4
Compare
tischsoic
commented
Apr 15, 2024
| {% set items_map = form.users.vars.data|reduce((output, user) => output|merge({ | ||
| "{{user.content.versionInfo.contentInfo.id}}": user.id | ||
| }), {}) %} | ||
| {% set items_map = form.users.vars.data|reduce((output, user) => output + { |
There was a problem hiding this comment.
Note: We have to use + to avoid numerical indexes reset caused by |merge
ref. twigphp/Twig#2741 (comment)
tischsoic
commented
Apr 15, 2024
| "{{user.content.versionInfo.contentInfo.id}}": user.id | ||
| }), {}) %} | ||
| {% set items_map = form.users.vars.data|reduce((output, user) => output + { | ||
| (user.content.versionInfo.contentInfo.id): user.id, |
There was a problem hiding this comment.
Note: “{{ some_variable }}“ solution does not work, variable should be surrounded with parentheses.
|
Gengar-i
approved these changes
Apr 15, 2024
lucasOsti
approved these changes
Apr 15, 2024
dew326
approved these changes
Apr 16, 2024
GrabowskiM
approved these changes
Apr 17, 2024
katarzynazawada
approved these changes
Apr 19, 2024
|
Merged up:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.