IBX-8254: Added check if relation is accessible #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mateuszdebinski
commented
May 7, 2024
mateuszdebinski
commented
| 🎫 Issue | IBX-8254 |
|---|
lucasOsti
approved these changes
May 7, 2024
src/bundle/Resources/views/themes/admin/content/tab/relations/table_relations.html.twig
Outdated
Show resolved
Hide resolved
mateuszdebinski
force-pushed
the
IBX-8254_error_relation_list_without_permission_to_content
branch
from
49f1684
to
c8c3f16
Compare
|
dew326
approved these changes
May 8, 2024
|
In relations tab there is a message displayed. I am not sure if we should reveal ID of content item that user doesn't have permission to read. Maybe member of UX team should look at that? |
barbaragr
approved these changes
May 9, 2024
dew326
deleted the
IBX-8254_error_relation_list_without_permission_to_content
branch
GrabowskiM
pushed a commit
that referenced
this pull request
May 27, 2024
Co-authored-by: Mateusz Dębiński <mateusz.debinski@ibexa.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.