IBX-8139: Dropped class_alias BC layer statements from all classes #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alongosz
force-pushed
the
ibx-8139-drop-legacy-class-aliases
branch
from
ed8922f
to
80cff01
Compare
alongosz
added
Doc needed
alongosz
requested review from
mikadamczyk,
Nattfarinn,
ciastektk,
ViniTou and
a team
konradoboza
approved these changes
May 23, 2024
ciastektk
approved these changes
May 23, 2024
Steveb-p
approved these changes
May 23, 2024
mikadamczyk
approved these changes
May 23, 2024
alongosz
force-pushed
the
ibx-8139-drop-legacy-class-aliases
branch
from
80cff01
to
5071905
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Dropped
class_aliasBC layer statements from all classes using ibexa/rector#2Note: CI issue (Browser tests) occurs on main as well.
Additionally
symfony/webpack-encore-bundlerequirement fromrequire-devsection (already present in therequiresection).Ibexa\AdminUi\Form\Type\Search\DateIntervalTypeand fixed its usage insrc/lib/Form/Type/Search/TrashSearchType.phptoIbexa\AdminUi\Form\Type\Date\DateIntervalTypeinstead. It's not very visible because that class existed in the same namespace asTrashSearchType. Whenclass_aliasgot removed, it stopped working.For QA:
No QA needed
Documentation:
Document that our BC layer has been dropped.
Ibexa\AdminUi\Form\Type\Search\DateIntervalTypehas been dropped andIbexa\AdminUi\Form\Type\Date\DateIntervalTypeshould be used instead.