Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8344: Added endpoint for download images #1271

Merged
merged 10 commits into from
Jun 5, 2024

Conversation

ciastektk
Copy link
Contributor

@ciastektk ciastektk commented May 31, 2024

🎫 Issue IBX-8344

Description:

For QA:

This PR adds new endpoint for download images used in Image picker.
When downloading several images a zip archive is created with all images.

Documentation:

@konradoboza konradoboza requested a review from a team June 3, 2024 06:29
Co-authored-by: Konrad Oboza <konrad.oboza@ibexa.co>
Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@konradoboza konradoboza requested a review from a team June 3, 2024 06:33
Co-authored-by: Konrad Oboza <konrad.oboza@ibexa.co>
@ciastektk ciastektk force-pushed the ibx-8344-added-endpoint-for-download-images branch from 975c528 to 79b727b Compare June 3, 2024 06:55
@Nattfarinn Nattfarinn requested a review from a team June 3, 2024 06:55
src/bundle/Controller/DownloadImageController.php Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@ciastektk ciastektk force-pushed the ibx-8344-added-endpoint-for-download-images branch from c70e875 to 2bb0281 Compare June 3, 2024 11:35
@ciastektk ciastektk force-pushed the ibx-8344-added-endpoint-for-download-images branch from b767015 to 12fb046 Compare June 3, 2024 12:23
@ciastektk ciastektk requested review from ViniTou, konradoboza, Nattfarinn and a team June 3, 2024 12:46
@ciastektk ciastektk force-pushed the ibx-8344-added-endpoint-for-download-images branch from 12fb046 to 86a754f Compare June 3, 2024 16:32
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have some test case covering unhappy path (enableMultipleDownload: false) but it's not a biggie.

@bogusez
Copy link
Contributor

bogusez commented Jun 5, 2024

@ciastektk when I send a request to get 2 or more files, downloaded file doesn't contains .zip extention. I have to add it manually to file name (tested through web browser and postman).

Screenshot 2024-06-05 at 09 28 32 Screenshot 2024-06-05 at 09 32 24

Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ciastektk ciastektk merged commit 2a0efe9 into 4.6 Jun 5, 2024
22 checks passed
@ciastektk ciastektk deleted the ibx-8344-added-endpoint-for-download-images branch June 5, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature request QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants