IBX-8424: Fixed criterions build for hook useSearchByQueryFetch #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tischsoic
approved these changes
Jun 24, 2024
tischsoic
reviewed
Jun 24, 2024
| fieldDefIdentifier: 'image', | ||
| ...imageCriterionData, | ||
| const imagesCriterion = damWidgetConfig.image.fieldDefinitionIdentifiers.reduce((criterions, fieldDefinitionIdentifier) => { | ||
| criterions = [ |
There was a problem hiding this comment.
I think that our eslint restricts reassignment of the function parameter value. 🤔
tischsoic
approved these changes
Jun 24, 2024
GrabowskiM
approved these changes
Jun 25, 2024
This was referenced Jun 27, 2024
lucasOsti
force-pushed
the
IBX-8424-folat-value-file-size-filter
branch
from
5b5a5ed
to
38b5c00
Compare
|
bogusez
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
It was necessary to getting fieldDefIdentifier value for ImageCriterion from the configuration and support for multiple fieldDefinitionIdentifiers
For QA:
Documentation: