Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7745: State for icon in search has wrong color #1281

Merged
merged 4 commits into from
Jul 24, 2024
Merged

IBX-7745: State for icon in search has wrong color #1281

merged 4 commits into from
Jul 24, 2024

Conversation

lucasOsti
Copy link
Contributor

@lucasOsti lucasOsti commented Jun 25, 2024 •
edited
Loading

🎫 Issue IBX-7745

Description:

Fixed UI of global search accordance with figma https://www.figma.com/design/4sbNQyNLhFFwxWDH89Rf9X/%F0%9F%9F%A2-Ibexa-Design-System?node-id=2761-94382&t=n0iyXpq8TlXx0NLc-0

For QA:

Documentation:

@lucasOsti lucasOsti force-pushed the IBX-7745-State-for-icon-in-search-has-wrong-color branch from c962598 to 7e451c4 Compare June 26, 2024 09:42
@lucasOsti lucasOsti changed the base branch from main to 4.6 June 26, 2024 09:43
@lucasOsti lucasOsti added Bug Something isn't working Ready for review and removed Work in progress labels Jun 26, 2024
@lucasOsti lucasOsti force-pushed the IBX-7745-State-for-icon-in-search-has-wrong-color branch from 7e451c4 to 8a10a8e Compare June 26, 2024 11:11
@lucasOsti lucasOsti changed the title IBX-7745: State for icon in search has wrong color [DRAFT] IBX-7745: State for icon in search has wrong color Jun 27, 2024
@lucasOsti lucasOsti requested a review from dew326 July 2, 2024 07:40
This was referenced Jul 8, 2024
Closed
Closed
@bogusez
Copy link
Contributor

bogusez commented Jul 8, 2024

  1. The search button within the search input is not highlighted when is in hover state
  2. An exception occurs for image asset CT when trying to trigger UDW (probably rebase will solve the issue).
Screenshot 2024-07-08 at 12 00 54

@bogusez bogusez self-assigned this Jul 9, 2024
@lucasOsti lucasOsti force-pushed the IBX-7745-State-for-icon-in-search-has-wrong-color branch from 8a10a8e to 31f6e32 Compare July 9, 2024 09:59
@lucasOsti lucasOsti requested a review from dew326 July 17, 2024 08:37
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@dew326 dew326 merged commit 4a41b1e into 4.6 Jul 24, 2024
24 checks passed
@dew326 dew326 deleted the IBX-7745-State-for-icon-in-search-has-wrong-color branch July 24, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@dew326 dew326 dew326 approved these changes

@bogusez bogusez bogusez approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@dew326 dew326

@ViniTou ViniTou

@bogusez bogusez

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lucasOsti @bogusez @GrabowskiM @dew326 @mikadamczyk @Nattfarinn @ciastektk @ViniTou