IBX-8110: ALW images edit #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
force-pushed
the
IBX-8110-ALW-images-edit
branch
6 times, most recently
from
70e230b
to
2fa91a6
Compare
lucasOsti
force-pushed
the
IBX-8110-ALW-images-edit
branch
4 times, most recently
from
5a46a77
to
e09efbc
Compare
tischsoic
reviewed
Jul 3, 2024
src/bundle/Resources/public/scss/ui/modules/common/_taggify.scss
Outdated
Show resolved
Hide resolved
lucasOsti
force-pushed
the
IBX-8110-ALW-images-edit
branch
3 times, most recently
from
c4fac33
to
6dda89f
Compare
tischsoic
approved these changes
Jul 5, 2024
GrabowskiM
approved these changes
Jul 8, 2024
dew326
reviewed
Jul 8, 2024
| font-size: $ibexa-text-font-size-medium; | ||
| color: var(--ibexa-input-text-color, var(--ibexa-text-color, $ibexa-color-dark)); | ||
| line-height: calculateRem(21px); | ||
| border: calculateRem(1px) solid var(--ibexa-input-border-color, #{$ibexa-color-dark-200}); |
There was a problem hiding this comment.
Suggested change
| border: calculateRem(1px) solid var(--ibexa-input-border-color, #{$ibexa-color-dark-200}); | |
| border: calculateRem(1px) solid var(--ibexa-input-border-color, $ibexa-color-dark-200); |
should work?
Comment on lines
38
to
40
| const filteredTags = tags.filter((tag) => tag.id !== id); | ||
|
|
||
| setTags(filteredTags); |
dew326
approved these changes
Jul 10, 2024
This was referenced Jul 17, 2024
lucasOsti
force-pushed
the
IBX-8110-ALW-images-edit
branch
from
39ff91c
to
05da2f5
Compare
dew326
approved these changes
Jul 23, 2024
GrabowskiM
approved these changes
Jul 23, 2024
lucasOsti
force-pushed
the
IBX-8110-ALW-images-edit
branch
from
05da2f5
to
226a6e2
Compare
|
bogusez
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Images action implementations:
For QA:
Required tests on DXP and standalone version
Documentation: