IBX-8647: MFU UI improvements #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
force-pushed
the
IBX-8647-MFU-modal-ui-improvements
branch
from
6321665
to
f5d073c
Compare
dew326
approved these changes
Jul 25, 2024
| overflow: auto; | ||
| margin-top: calculateRem(16px); | ||
| margin: calculateRem(16px) 0; | ||
| max-height: calc(90vh - 473px); |
There was a problem hiding this comment.
Suggested change
| max-height: calc(90vh - 473px); | |
| max-height: calc(90vh - calculateRem(473px)); |
GrabowskiM
requested changes
Jul 26, 2024
| @@ -96,6 +96,7 @@ export default class UploadPopupModule extends Component { | |||
| closeBtnAttrs: { | |||
| disabled: !itemsToUpload.length, | |||
| }, | |||
| ...((hasAnyUploadedItems || hasAnyItemsToUpload) && { extraClasses: 'c-tooltip-popup--with-uploaded-items' }), | |||
There was a problem hiding this comment.
Personally I don't like this form, imho it's hard to read, I would do it as normal if below
if (hasAnyUploadedItems || hasAnyItemsToUpload) {
tooltipAttrs.extraClasses = 'c-tooltip-popup--with-uploaded-items';
}
dew326
approved these changes
Jul 26, 2024
GrabowskiM
approved these changes
Jul 26, 2024
lucasOsti
force-pushed
the
IBX-8647-MFU-modal-ui-improvements
branch
from
af50f53
to
06a8fdd
Compare
This was referenced Jul 30, 2024
Screen.Recording.2024-07-30.at.13.34.49.mov |
bogusez
requested changes
Aug 1, 2024
lucasOsti
force-pushed
the
IBX-8647-MFU-modal-ui-improvements
branch
from
06a8fdd
to
089494a
Compare
|
GrabowskiM
approved these changes
Aug 2, 2024
bogusez
approved these changes
Aug 2, 2024
dew326
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
Modal without uploaded items:
Modal with uploaded items:
For QA:
DXP and standalone version test required
Documentation: