-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-8800: Fixed subitems filtering #1328
Conversation
src/bundle/ControllerArgumentResolver/ContentTreeChildrenQueryArgumentResolver.php
Outdated
Show resolved
Hide resolved
src/bundle/ControllerArgumentResolver/ContentTreeChildrenQueryArgumentResolver.php
Outdated
Show resolved
Hide resolved
ff28fa7
to
e5d1789
Compare
src/bundle/ControllerArgumentResolver/ContentTreeChildrenQueryArgumentResolver.php
Outdated
Show resolved
Hide resolved
e5d1789
to
e143783
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming this is internal code: +1
e143783
to
0e449f9
Compare
0e449f9
to
f95a231
Compare
f95a231
to
bc132ba
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested using Elastic, Solr and Legacy search engines
Description:
Currently
LogicalAnd
criterion is always added to query viaContentTreeChildrenQueryArgumentResolver
andContentTreeController::loadChildrenAction
. When using solr or elasticserach engine and filter parameter is not passed to request, exception aboutInvalid aggregation in LogicalAnd criterion
is throw.This PR changes type hint of
$filter
parameter fromCriterion
to?Criterion
inContentTreeController::loadChildrenAction
. This allows to yield null value inContentTreeChildrenQueryArgumentResolver::resolve
when processed array of filter criteria is empty.For QA:
Documentation: