IBX-1802: Update design for location swap and table locations #146
Conversation
lucasOsti
force-pushed
the
IBX-1802-location-swap
branch
from
8e5cc4f
to
4cd6bb4
Compare
| @@ -0,0 +1,12 @@ | |||
| .ibexa-form-location-swap { | |||
There was a problem hiding this comment.
| .ibexa-form-location-swap { | |
| .ibexa-location-swap-form { |
| name="updateVisibility" | ||
| {{ not can_hide[location.id] ? 'disabled' }} | ||
| class="ibexa-input ibexa-input--radio" | ||
| type="radio" |
There was a problem hiding this comment.
Are you sure? I think that the old type (checkbox) is the correct one.
| type="radio" | |
| type="checkbox" |
There was a problem hiding this comment.
According to the invsion project, there should be a radio here
Current:
Invsion:
https://projects.invisionapp.com/d/main#/console/21797486/461599772/preview
There was a problem hiding this comment.
Oh, you are right, I was confused because the order of the columns has been changed. :)
|
|
||
| {% set col_raw %} | ||
| <label | ||
| class="ibexa-checkbox-icon {{ not location.explicitlyHidden ? 'is-checked' }}{{ not can_hide[location.id] ? 'disabled' }}" |
There was a problem hiding this comment.
Can we delete ibexa-checkbox-icon styles? I may be wrong, but it seems that it is only used here.
(There is one occurrence in JS in Page Builder, but it is only JS and probably is a dead code and should be deleted.)
| {% endembed %} | ||
| {% set col_raw %} | ||
| <div class="ibexa-content-locations__visibility-toggler"> | ||
| <div class="ibexa-toggle ibexa-toggle--checkbox {{ not can_hide[location.id] ? 'ibexa-toggle--is-disabled' }} {{ not location.explicitlyHidden ? 'ibexa-toggle--is-checked' }}"> |
There was a problem hiding this comment.
Can we import toggle_widget.html.twig here?
There was a problem hiding this comment.
I guess I can't use the toggle widget here because it is a block
There was a problem hiding this comment.
As discussed in private: for now, it is not possible to include toggle_widget.html.twig.
Checklist:
$ composer fix-cs)