Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-1765: Added customize label on/off for toggle widget #169

Conversation

lucasOsti
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-1765
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@@ -1,4 +1,6 @@
{%- block toggle_widget -%}
{% set default_label_on = 'toggle_widget.label.on'|trans|desc('On') %}
{% set default_label_off = 'toggle_widget.label.on'|trans|desc('Off') %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{% set default_label_off = 'toggle_widget.label.on'|trans|desc('Off') %}
{% set default_label_off = 'toggle_widget.label.off'|trans|desc('Off') %}

@adamwojs adamwojs merged commit c5279a6 into ibexa:main Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature request Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants