IBX-1476: Disable Select All checkbox when all the checkboxes in the table row are disabled #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…table row are disabled
2 tasks
GrabowskiM
requested review from
tischsoic,
dew326 and
lucasOsti
and removed request for
tischsoic
dew326
approved these changes
Jan 25, 2022
tischsoic
requested changes
Jan 25, 2022
| @@ -82,6 +82,7 @@ | |||
| }) }} | |||
| {% include '@ibexadesign/ui/component/table/table.html.twig' with { | |||
| headline: 'bookmark.table.header'|trans|desc('Bookmarks') ~ ' (' ~ pager.count ~ ')', | |||
| class: 'ibexa-table--has-bulk-checkbox', | |||
There was a problem hiding this comment.
I think this should be done as a separate table component property e.g. has_bulk_checkbox: true to ensure table component encapsulation.
lucasOsti
approved these changes
Jan 26, 2022
tischsoic
approved these changes
Jan 26, 2022
| @@ -52,6 +52,12 @@ | |||
|
|
|||
| const checkboxesChangeListeners = new Map(); | |||
| headCellsWithCheckboxes.forEach((headCellsWithCheckbox) => { | |||
| const hasBulkCheckbox = !!headCellsWithCheckbox.querySelector('.ibexa-table__header-cell-checkbox:not(.ibexa-table__header-cell-checkbox--custom-init)'); | |||
There was a problem hiding this comment.
Suggested change
| const hasBulkCheckbox = !!headCellsWithCheckbox.querySelector('.ibexa-table__header-cell-checkbox:not(.ibexa-table__header-cell-checkbox--custom-init)'); | |
| const isCustomInit = !!headCellsWithCheckbox.querySelector('.ibexa-table__header-cell-checkbox:not(.ibexa-table__header-cell-checkbox--custom-init)'); |
dew326
approved these changes
Jan 26, 2022
dew326
deleted the
IBX-1476-disable-select-all-checkbox-when-all-the-checkboxes-in-the-table-row-are-disabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)