Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-2164: Added tooltips in bookmarks list in udw #288

Merged
merged 2 commits into from
Feb 1, 2022
Merged

IBX-2164: Added tooltips in bookmarks list in udw #288

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f43489
IBX-2164: Added tooltips in bookmarks list in udw
dew326 Feb 1, 2022
8a8eae3
after review
dew326 Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions ...bundle/ui-dev/src/modules/universal-discovery/components/bookmarks-list/bookmarks.list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useContext, useState, useEffect } from 'react';
import React, { useContext, useState, useEffect, useRef } from 'react';
import PropTypes from 'prop-types';

import Icon from '../../../common/icon/icon';
Expand All @@ -18,6 +18,7 @@ import {
const SCROLL_OFFSET = 200;

const BookmarksList = ({ setBookmarkedLocationMarked, itemsPerPage }) => {
const refBookmarksList = useRef(null);
const [offset, setOffset] = useState(0);
const [bookmarks, setBookmarks] = useState([]);
const [markedLocationId, setMarkedLocationId] = useContext(MarkedLocationIdContext);
Expand Down Expand Up @@ -58,12 +59,16 @@ const BookmarksList = ({ setBookmarkedLocationMarked, itemsPerPage }) => {
setBookmarks((prevState) => [...prevState, ...data.items]);
}, [data.items, isLoading]);

useEffect(() => {
window.ibexa.helpers.tooltips.parse(refBookmarksList.current);
}, [bookmarks]);

if (!bookmarks.length) {
return null;
}

return (
<div className="c-bookmarks-list" onScroll={loadMore}>
<div className="c-bookmarks-list" onScroll={loadMore} ref={refBookmarksList}>
{bookmarks.map((bookmark) => {
const isMarked = bookmark.id === markedLocationId;
const contentTypeInfo = contentTypesMap[bookmark.ContentInfo.Content.ContentType._href];
Expand All @@ -90,7 +95,13 @@ const BookmarksList = ({ setBookmarkedLocationMarked, itemsPerPage }) => {
};

return (
<div key={bookmark.id} className={className} onClick={markLocation}>
<div
key={bookmark.id}
className={className}
onClick={markLocation}
title={bookmark.ContentInfo.Content.TranslatedName}
data-tooltip-container-selector=".c-bookmarks-list"
>
<Icon extraClasses="ibexa-icon--small" customPath={contentTypeInfo.thumbnail} />
<span className="c-bookmarks-list__item-name">{bookmark.ContentInfo.Content.TranslatedName}</span>
</div>
Expand Down