IBX-2399: Introduce reusable twig modal component #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tischsoic
commented
Feb 21, 2022
| @@ -296,7 +296,7 @@ $modal-header-border-color: $ibexa-color-light-500; | |||
| $modal-title-font-size: 28px; | |||
| $modal-content-border-width: 0; | |||
| $modal-content-border-radius: $ibexa-border-radius; | |||
| $modal-inner-padding: 24px 0; | |||
| $modal-inner-padding: calculateRem(24px); | |||
There was a problem hiding this comment.
This has to be single value in rem because it is used in such expression in bootstrap scss internals:
padding: $modal-inner-padding - $modal-footer-margin-between * .5;
ref. https://github.com/ibexa/admin-ui-assets/blob/792cd47c43ab5cc05609e6a45242ef87934d5afb/src/bundle/Resources/public/vendors/bootstrap/scss/_modal.scss#L131
otherwise it produces:
tischsoic
commented
Feb 21, 2022
| @@ -3,5 +3,5 @@ | |||
| @function calculateRem($size) { | |||
| $remSize: div($size, $base-font-size); | |||
|
|
|||
| @return #{$remSize}rem; | |||
| @return $remSize + 0rem; | |||
There was a problem hiding this comment.
The previous version was actually not converting values to rem measurement in SCSS. Change required for $modal-inner-padding;
tischsoic
force-pushed
the
IBX-2399-introduce-modal-twig-component
branch
from
80b8b9f
to
fde381a
Compare
lucasOsti
approved these changes
Feb 24, 2022
dew326
reviewed
Feb 24, 2022
|
|
||
| {% set no_header = no_header|default(false) %} | ||
|
|
||
| {% set size = size|default(false) %} |
There was a problem hiding this comment.
as discussed in private, no mixed type.
GrabowskiM
approved these changes
Feb 25, 2022
tischsoic
force-pushed
the
IBX-2399-introduce-modal-twig-component
branch
from
fde381a
to
0855b1e
Compare
dew326
approved these changes
Mar 1, 2022
tischsoic
force-pushed
the
IBX-2399-introduce-modal-twig-component
branch
from
ef2d1fd
to
a457541
Compare
dew326
approved these changes
Mar 4, 2022
lucasOsti
approved these changes
Mar 4, 2022
micszo
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs: