Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-1488:[Redesign commerce cockpit]: Added bar chart #60

Merged

Conversation

lucasOsti
Copy link
Contributor

@lucasOsti lucasOsti commented Nov 22, 2021

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-1488
Bug fix? no
New feature? no
BC breaks? yes
Tests pass? no
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@lucasOsti lucasOsti marked this pull request as draft November 22, 2021 08:40
@lucasOsti lucasOsti changed the title [WIP]IBX-1488:[Redesign commerce cockpit]: Added bar chart IBX-1488:[Redesign commerce cockpit]: Added bar chart Nov 23, 2021
@lucasOsti lucasOsti marked this pull request as ready for review November 23, 2021 16:09
}

eZ.addConfig('core.chart.BarChart', BarChart);
})(window, window.document, window.eZ, window.Chart);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove window.Chart

@@ -247,6 +247,9 @@
<symbol id="date" viewBox="0 0 32 32" xmlns="http://www.w3.org/2000/svg">
<path d="M19.667 4h-7.333c-0.736 0-1.333-0.597-1.333-1.333s0.597-1.333 1.333-1.333v0h7.333c0.736 0 1.333 0.597 1.333 1.333s-0.597 1.333-1.333 1.333v0zM32 4.223v24.887c0 0.001 0 0.002 0 0.003 0 1.591-1.287 2.881-2.876 2.887h-26.247c-1.59-0.006-2.877-1.296-2.877-2.887 0-0.001 0-0.002 0-0.004v0-24.897c0 0 0 0 0-0 0-1.587 1.284-2.874 2.869-2.88h1.464c0.736 0 1.333 0.597 1.333 1.333s-0.597 1.333-1.333 1.333v0h-1.463c-0.113 0.004-0.203 0.096-0.203 0.21 0 0.001 0 0.002 0 0.004v-0 7.12h26.667v-7.11c0-0.001 0-0.002 0-0.003 0-0.119-0.095-0.216-0.213-0.22h-1.454c-0.736 0-1.333-0.597-1.333-1.333s0.597-1.333 1.333-1.333v0h1.453c1.591 0.004 2.88 1.295 2.88 2.887 0 0.001 0 0.002 0 0.004v-0zM29.333 29.11v-15.11h-26.667v15.11c-0 0.001-0 0.002-0 0.004 0 0.118 0.093 0.214 0.21 0.22l0.001 0h26.247c0.117-0.004 0.21-0.099 0.21-0.217 0-0.002-0-0.005-0-0.007v0zM9.667 5.027s0-0.027 0-0.027v-3.667c0-0.736-0.597-1.333-1.333-1.333s-1.333 0.597-1.333 1.333v0 3.667s0 0.017 0 0.027c-0.803 0.47-1.333 1.328-1.333 2.309 0 1.473 1.194 2.667 2.667 2.667s2.667-1.194 2.667-2.667c0-0.982-0.531-1.84-1.321-2.303l-0.013-0.007zM25 5.027s0-0.027 0-0.027v-3.667c0-0.736-0.597-1.333-1.333-1.333s-1.333 0.597-1.333 1.333v0 3.667s0 0.017 0 0.027c-0.803 0.47-1.333 1.328-1.333 2.309 0 1.473 1.194 2.667 2.667 2.667s2.667-1.194 2.667-2.667c0-0.982-0.531-1.84-1.321-2.303l-0.013-0.007z"></path>
</symbol>
<symbol id="database" viewBox="0 0 32 32" xmlns="http://www.w3.org/2000/svg">
<path d="M19.9285714,6.65774033 C25.9756182,6.65774033 31,8.8894344 31,12.1900721 L31,12.1900721 L31,25.4676681 C31,28.7688928 25.9759759,30.9999998 19.9285714,30.9999998 C14.0701482,30.9999998 9.17214374,28.9061581 8.87173958,25.7739874 L8.85714284,25.4676681 L8.85714284,12.1900721 L8.86192655,12.0142814 C9.03691116,8.81044268 13.9895077,6.65774033 19.9285714,6.65774033 Z M19.9285714,24.3612018 C16.3344785,24.3612018 13.1018601,23.5731388 11.070545,22.2407315 L11.0714286,25.4676681 C11.0714286,27.0561754 14.9690638,28.7870672 19.9285714,28.7870672 C24.7109538,28.7870672 28.5059573,27.1776028 28.770929,25.6383248 L28.7857143,25.4676681 L28.7865979,22.2407315 C26.7552827,23.5731388 23.5226643,24.3612018 19.9285714,24.3612018 Z M20.2879391,2.39634578 C20.808507,2.71691469 20.9704793,3.39853292 20.6497143,3.91878268 C20.3289494,4.43903244 19.6469144,4.60090575 19.1263465,4.28033684 C16.7288421,2.80393867 13.9395682,2.08917726 11.0714286,2.23187497 C6.12029077,2.23187497 2.21428571,3.96947943 2.21428571,5.55127399 C2.21428571,6.26195973 3.11271998,7.13565955 4.83840584,7.82289051 C5.4064277,8.0490975 5.68341128,8.69266584 5.45706598,9.2603406 C5.23072068,9.82801536 4.58675886,10.1048297 4.01873701,9.87862272 C3.34362301,9.60976773 2.73771174,9.30242292 2.21350598,8.96022808 L2.21428571,12.1900721 C2.21428571,12.9007578 3.11271998,13.7744576 4.83840584,14.4616886 C5.4064277,14.6878955 5.68341128,15.3314639 5.45706598,15.8991387 C5.23072068,16.4668134 4.58675886,16.7436277 4.01873701,16.5174208 C3.34362301,16.2485658 2.73771174,15.9412209 2.21350598,15.5990261 L2.21428571,18.82887 C2.21428571,19.5395558 3.11271998,20.4132556 4.83840584,21.1004866 C5.4064277,21.3266936 5.68341128,21.9702619 5.45706598,22.5379366 C5.23072068,23.1056115 4.58675886,23.3824258 4.01873701,23.1562188 C1.69021863,22.2289179 0.184943586,20.8437377 0.0159095615,19.1500211 L0,18.82887 L0,5.55127399 C0,2.2578233 5.0328373,0.0189422864 11.0158421,0.0203377345 C14.2758977,-0.143446982 17.5089701,0.6850394 20.2879391,2.39634578 Z M28.7864929,15.601681 C26.7551102,16.9341333 23.5224517,17.7224037 19.9285714,17.7224037 C16.3346912,17.7224037 13.1020327,16.9341333 11.0706499,15.601681 L11.0714286,18.82887 C11.0714286,20.4173775 14.9690638,22.1482691 19.9285714,22.1482691 C24.7109538,22.1482691 28.5059573,20.5388048 28.770929,18.9995268 L28.7857143,18.82887 L28.7864929,15.601681 Z M19.9285714,8.870673 C14.9693721,8.870673 11.0714286,10.6020338 11.0714286,12.1900721 C11.0714286,13.7781103 14.9693721,15.509471 19.9285714,15.509471 C24.8877707,15.509471 28.7857143,13.7781103 28.7857143,12.1900721 C28.7857143,10.6020338 24.8877707,8.870673 19.9285714,8.870673 Z" id="Combined-Shape"></path>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id="Combined-Shape" should be removed.

@@ -0,0 +1,3 @@
<svg width="32px" height="32px" viewBox="0 0 32 32" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
<path d="M19.9285714,6.65774033 C25.9756182,6.65774033 31,8.8894344 31,12.1900721 L31,12.1900721 L31,25.4676681 C31,28.7688928 25.9759759,30.9999998 19.9285714,30.9999998 C14.0701482,30.9999998 9.17214374,28.9061581 8.87173958,25.7739874 L8.85714284,25.4676681 L8.85714284,12.1900721 L8.86192655,12.0142814 C9.03691116,8.81044268 13.9895077,6.65774033 19.9285714,6.65774033 Z M19.9285714,24.3612018 C16.3344785,24.3612018 13.1018601,23.5731388 11.070545,22.2407315 L11.0714286,25.4676681 C11.0714286,27.0561754 14.9690638,28.7870672 19.9285714,28.7870672 C24.7109538,28.7870672 28.5059573,27.1776028 28.770929,25.6383248 L28.7857143,25.4676681 L28.7865979,22.2407315 C26.7552827,23.5731388 23.5226643,24.3612018 19.9285714,24.3612018 Z M20.2879391,2.39634578 C20.808507,2.71691469 20.9704793,3.39853292 20.6497143,3.91878268 C20.3289494,4.43903244 19.6469144,4.60090575 19.1263465,4.28033684 C16.7288421,2.80393867 13.9395682,2.08917726 11.0714286,2.23187497 C6.12029077,2.23187497 2.21428571,3.96947943 2.21428571,5.55127399 C2.21428571,6.26195973 3.11271998,7.13565955 4.83840584,7.82289051 C5.4064277,8.0490975 5.68341128,8.69266584 5.45706598,9.2603406 C5.23072068,9.82801536 4.58675886,10.1048297 4.01873701,9.87862272 C3.34362301,9.60976773 2.73771174,9.30242292 2.21350598,8.96022808 L2.21428571,12.1900721 C2.21428571,12.9007578 3.11271998,13.7744576 4.83840584,14.4616886 C5.4064277,14.6878955 5.68341128,15.3314639 5.45706598,15.8991387 C5.23072068,16.4668134 4.58675886,16.7436277 4.01873701,16.5174208 C3.34362301,16.2485658 2.73771174,15.9412209 2.21350598,15.5990261 L2.21428571,18.82887 C2.21428571,19.5395558 3.11271998,20.4132556 4.83840584,21.1004866 C5.4064277,21.3266936 5.68341128,21.9702619 5.45706598,22.5379366 C5.23072068,23.1056115 4.58675886,23.3824258 4.01873701,23.1562188 C1.69021863,22.2289179 0.184943586,20.8437377 0.0159095615,19.1500211 L0,18.82887 L0,5.55127399 C0,2.2578233 5.0328373,0.0189422864 11.0158421,0.0203377345 C14.2758977,-0.143446982 17.5089701,0.6850394 20.2879391,2.39634578 Z M28.7864929,15.601681 C26.7551102,16.9341333 23.5224517,17.7224037 19.9285714,17.7224037 C16.3346912,17.7224037 13.1020327,16.9341333 11.0706499,15.601681 L11.0714286,18.82887 C11.0714286,20.4173775 14.9690638,22.1482691 19.9285714,22.1482691 C24.7109538,22.1482691 28.5059573,20.5388048 28.770929,18.9995268 L28.7857143,18.82887 L28.7864929,15.601681 Z M19.9285714,8.870673 C14.9693721,8.870673 11.0714286,10.6020338 11.0714286,12.1900721 C11.0714286,13.7781103 14.9693721,15.509471 19.9285714,15.509471 C24.8877707,15.509471 28.7857143,13.7781103 28.7857143,12.1900721 C28.7857143,10.6020338 24.8877707,8.870673 19.9285714,8.870673 Z" id="Combined-Shape"></path>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we have also id="Combined-Shape"

@dew326 dew326 merged commit d7d032a into ibexa:main Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants