IBX-3901: Add empty field after bulk delete all authors #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tischsoic
reviewed
Oct 24, 2022
| @@ -118,6 +118,12 @@ | |||
|
|
|||
| bulkDeleteButton.setAttribute('disabled', 'disabled'); | |||
|
|
|||
| const authorRowsExist = !!container.querySelector(SELECTOR_AUTHOR); | |||
There was a problem hiding this comment.
Not sure but maybe:
Suggested change
| const authorRowsExist = !!container.querySelector(SELECTOR_AUTHOR); | |
| const authorsRowsExist = !!container.querySelector(SELECTOR_AUTHOR); |
There was a problem hiding this comment.
This checks if at least one author row exists so authorRowExists?
lucasOsti
approved these changes
Oct 24, 2022
tischsoic
approved these changes
Oct 27, 2022
GrabowskiM
force-pushed
the
IBX-3901-author-bulk-delete-fix
branch
from
246d746
to
ef9a00e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
katarzynazawada
approved these changes
Nov 3, 2022
dew326
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)