IBX-3301: Product type - disable button Add when there is no option to add more elements #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o add more elements
dew326
requested changes
Oct 27, 2022
| const addGroupBtns = doc.querySelectorAll('.ibexa-content-type-edit__add-field-definitions-group [data-related-collapse-selector]'); | ||
| const areEveryAddGroupBtnsDisabled = [...addGroupBtns].every(btn => btn.classList.contains('ibexa-popup-menu__item-content--disabled')); | ||
|
|
||
| addGroupTriggerBtn.disabled = areEveryAddGroupBtnsDisabled |
| }, | ||
| }); | ||
| const toggleAddGroupTriggerBtn = () => { |
There was a problem hiding this comment.
Suggested change
| const toggleAddGroupTriggerBtn = () => { | |
| const toggleAddGroupTriggerBtnState = () => { |
?
tischsoic
approved these changes
Oct 27, 2022
dew326
approved these changes
Oct 27, 2022
Gengar-i
approved these changes
Oct 27, 2022
GrabowskiM
requested changes
Oct 27, 2022
| }, | ||
| }); | ||
| const toggleAddGroupTriggerBtnState = () => { | ||
| const addGroupBtns = doc.querySelectorAll('.ibexa-content-type-edit__add-field-definitions-group [data-related-collapse-selector]'); | ||
| const areEveryAddGroupBtnsDisabled = [...addGroupBtns].every((btn) => |
There was a problem hiding this comment.
Suggested change
| const areEveryAddGroupBtnsDisabled = [...addGroupBtns].every((btn) => | |
| const areAllAddGroupBtnsDisabled = [...addGroupBtns].every((btn) => |
is best. (also as a sidenote - if you use "every", all other words should be singular, so in that case "isEveryAddGroupBtnDisabled"), but still - best one is one in suggestion ;)
| @@ -471,4 +481,5 @@ | |||
| }, | |||
| false, | |||
| ); | |||
| toggleAddGroupTriggerBtnState(); | |||
There was a problem hiding this comment.
Suggested change
| toggleAddGroupTriggerBtnState(); | |
| toggleAddGroupTriggerBtnState(); |
GrabowskiM
approved these changes
Oct 27, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
bogusez
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)