Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5280: Added constraint LocationIsContainer to parentLocation in ContentCreateData #734

Merged
merged 1 commit into from
Sep 25, 2023
Merged

IBX-5280: Added constraint LocationIsContainer to parentLocation in ContentCreateData #734

merged 1 commit into from
Sep 25, 2023

Conversation

papcio122
Copy link
Contributor

@papcio122 papcio122 commented Mar 16, 2023 •
edited
Loading

Question Answer
Tickets IBX-5280
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@papcio122 papcio122 changed the base branch from main to 4.4 March 16, 2023 12:37
@sonarcloud
Copy link

sonarcloud bot commented Mar 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@papcio122 papcio122 requested a review from a team March 16, 2023 13:06
@papcio122 papcio122 requested review from a team and removed request for a team March 21, 2023 10:49
@adamwojs
Copy link
Member

@papcio122 Could you please change target branch to 4.5 ?

@adamwojs adamwojs changed the title IBX-5280 added constraint LocationIsContainer to parentLocation in ContentCreateData IBX-5280: Added constraint LocationIsContainer to parentLocation in ContentCreateData Jul 31, 2023
@papcio122 papcio122 changed the base branch from 4.4 to 4.5 July 31, 2023 07:28
@papcio122 papcio122 force-pushed the IBX-5280_fix_validation_isContainer_parent_location_for_creating_new_content branch from f7fed41 to 6a12bfe Compare August 1, 2023 08:18
@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@papcio122 papcio122 added Bug Something isn't working Ready for QA and removed Ready for review labels Aug 8, 2023
krzbro
krzbro suggested changes Sep 4, 2023
View reviewed changes
Copy link

@krzbro krzbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some unexpected behavior:

  1. After unsuccessful content creation, we get redirected to the dashboard.
  2. In the context menu of non-container elements, the option to create content is still available.

@mateuszbieniek
Copy link
Contributor

Hi @papcio122 - can you take a look at the comment from QA?

@papcio122
Copy link
Contributor Author

@krzbro

In the context menu of non-container elements, the option to create content is still available.

For this I needed to create PR in another repo: https://github.com/ibexa/content-tree/pull/49

@ViniTou ViniTou merged commit e48263d into 4.5 Sep 25, 2023
14 checks passed
@ViniTou ViniTou deleted the IBX-5280_fix_validation_isContainer_parent_location_for_creating_new_content branch September 25, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@kisztof kisztof kisztof approved these changes

@webhdx webhdx webhdx approved these changes

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

@krzbro krzbro krzbro approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@ViniTou ViniTou

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.