IBX-4012: [Sections] Recalculate last section padding on section height change #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
approved these changes
Apr 19, 2023
tischsoic
approved these changes
Apr 19, 2023
Gengar-i
approved these changes
Apr 19, 2023
dew326
approved these changes
Apr 19, 2023
GrabowskiM
force-pushed
the
recalculate-padding-on-section-height-change
branch
from
f185b62
to
f56a65a
Compare
GrabowskiM
changed the title
GrabowskiM
force-pushed
the
recalculate-padding-on-section-height-change
branch
from
f56a65a
to
be4667e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to recalculate last section padding in case of when there is dynamically loaded content, as it changes content height and breaks proper selecting of active section in left nav menu
Checklist:
$ composer fix-cs)