IBX-5565: Add reusable delete confirmation modal #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
requested changes
Apr 21, 2023
| <trans-unit id="99aa2f672dfd9206b58ddf5d78e6a695ceb9ebf1" resname="field_definition.ezuser.require_not_compromised_password_help"> | ||
| <source>This uses the API at %link% to securely check breach data. The password is not transmitted to the API.</source> | ||
| <target state="new">This uses the API at %link% to securely check breach data. The password is not transmitted to the API.</target> | ||
| <note>key: field_definition.ezuser.require_not_compromised_password_help</note> |
There was a problem hiding this comment.
This translation is from a recent feature and I believe shouldn't be removed. But why extractor is removing it?
There was a problem hiding this comment.
fixed in ddaa268 . By default jms translation extractor is not able to extract from help option.
|
Kudos, SonarCloud Quality Gate passed!
|
dew326
approved these changes
Apr 24, 2023
lucasOsti
approved these changes
Apr 24, 2023
tischsoic
reviewed
Apr 24, 2023
src/bundle/Resources/views/themes/admin/ui/modal/delete_confirmation.html.twig
Show resolved
Hide resolved
Gengar-i
approved these changes
Apr 25, 2023
tischsoic
approved these changes
Apr 25, 2023
bogusez
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)