IBX-6123: Fixed tooltips ellipsis #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
force-pushed
the
IBX-6123-fixed-title-ellipsis
branch
from
c7d47be
to
6860497
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
bogusez
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking whether the text goes beyond the container by the condition
tooltipNode.scrollWidth > tooltipNode.offsetWidthis not very precise becausescrollWidthandoffsetWidthreturn a value as a natural number and in some cases the difference was less than 1.To check if the text goes beyond the container, I create a temporary html node and set the values for
Finally I check if the temporary node has a higher height value than the source node, if so, it means that it is outside the container.
Checklist:
$ composer fix-cs)