Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-6261: Fixed UDW Search module to set locations when unmounting #861

Merged
merged 4 commits into from
Aug 24, 2023

Conversation

barw4
Copy link
Contributor

@barw4 barw4 commented Aug 5, 2023

Question Answer
Tickets IBX-6261
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

When switching from Search module locations were cleared, this shouldn't be the case now.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 added Bug Something isn't working Ready for review labels Aug 5, 2023
@barw4 barw4 requested a review from a team August 5, 2023 10:23
@barw4 barw4 self-assigned this Aug 5, 2023
@GrabowskiM GrabowskiM requested review from tischsoic, lucasOsti and Gengar-i and removed request for Gengar-i August 7, 2023 06:40
@barw4 barw4 requested a review from GrabowskiM August 7, 2023 09:00
@barw4 barw4 requested a review from dew326 August 22, 2023 08:44
@barw4 barw4 force-pushed the ibx-6261-udw-search-set-locations branch from 33166a7 to e57a649 Compare August 23, 2023 11:46
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dew326 dew326 merged commit 516741f into 4.5 Aug 24, 2023
14 checks passed
@dew326 dew326 deleted the ibx-6261-udw-search-set-locations branch August 24, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants