Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5743: Fixed header z-index in edit mode #888

Merged
merged 2 commits into from
Sep 1, 2023
Merged

IBX-5743: Fixed header z-index in edit mode #888

merged 2 commits into from
Sep 1, 2023

Conversation

dew326
Copy link
Contributor

@dew326 dew326 commented Aug 30, 2023

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-5743
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@dew326 dew326 self-assigned this Aug 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@micszo micszo self-assigned this Sep 1, 2023
micszo
micszo approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested across main browsers.

QA Approved on Ibexa Commerce 4.5.3-dev with diff.

@micszo micszo removed their assignment Sep 1, 2023
@dew326 dew326 merged commit 994337f into 4.5 Sep 1, 2023
14 checks passed
@dew326 dew326 deleted the fix-index-header branch September 1, 2023 09:11
mnocon added a commit that referenced this pull request Sep 6, 2023
@mnocon
Revert "IBX-5743: Fixed header z-index in edit mode (#888)"
27a5c80 
This reverts commit 994337f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@tischsoic tischsoic tischsoic approved these changes

@micszo micszo micszo approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@Gengar-i Gengar-i Gengar-i approved these changes

Assignees

@dew326 dew326

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dew326 @GrabowskiM @tischsoic @micszo @lucasOsti @Gengar-i