Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7894: Added missing languages for DeepL and bumped API version to v2 #15

Open
wants to merge 3 commits into
base: 4.6
Choose a base branch
from

Conversation

mateuszdebinski
Copy link
Contributor

@mateuszdebinski mateuszdebinski commented Jul 29, 2024

🎫 Issue IBX-7894

Description:

Added missing languages for DeepL because our list was very old and some code of languages are deprecated. Also, bumped the API version to v2 as version v1 is no longer supported.

The source_lang accepts only two letters of language code

For QA:

Documentation:

@mateuszdebinski mateuszdebinski added Bug Something isn't working Ready for review labels Jul 29, 2024
@mateuszdebinski mateuszdebinski requested a review from a team July 29, 2024 13:06
@mateuszdebinski mateuszdebinski self-assigned this Jul 29, 2024
@adamwojs
Copy link
Member

@mateuszdebinski Could you please provide some minimal PR description?

src/lib/Client/Deepl.php Outdated Show resolved Hide resolved
@mateuszdebinski mateuszdebinski requested review from adamwojs and a team September 24, 2024 11:00
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mateuszdebinski

src/lib/Client/Deepl.php Outdated Show resolved Hide resolved
src/lib/Client/Deepl.php Outdated Show resolved Hide resolved
src/lib/Client/Deepl.php Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 24, 2024

@bogusez
Copy link

bogusez commented Oct 2, 2024

@mateuszdebinski after applying patch I have an issue

Screenshot 2024-10-02 at 13 36 09

@bogusez
Copy link

bogusez commented Oct 7, 2024

@mateuszdebinski there is also an issue with missing service on Headless edition. Automated translation feature not working: https://issues.ibexa.co/browse/IBX-8992

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready for QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants