Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8422: Update scripts for PHP 8.3 as default when releasing tags #91

Merged
merged 6 commits into from
Jul 10, 2024
Merged

IBX-8422: Update scripts for PHP 8.3 as default when releasing tags #91

merged 6 commits into from
Jul 10, 2024

Conversation

micszo
Copy link
Contributor

@micszo micszo commented Jun 25, 2024 •
edited
Loading

🎫 Issue IBX-8422

Description:

Things to double-check:

  1. Presence of error handler hiding deprecations from PHP 8.2 up in all scripts
  2. Default PHP 8.3 image (covered for majority of places in Bump default image to PHP 8.3 gh-workflows#51)
  3. Sequence of composer commands (https://doc.ibexa.co/en/latest/getting_started/install_ibexa_dxp/#create-project) in stable script

TODO:

  • decide about PHP_IMAGE for "stable" directory (7c34f26)

For QA:

Documentation:

@micszo micszo changed the title IBX-8422: Bump default image to PHP 8.3 IBX-8422: Update scripts for PHP 8.3 as default when releasing tags Jul 2, 2024
@micszo micszo marked this pull request as ready for review July 2, 2024 12:03
mnocon
mnocon reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed another thing, sorry about that 🙈

bin/stable/prepare_project_edition.sh Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

mnocon
mnocon approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 😄

@micszo micszo merged commit c7e11b1 into main Jul 10, 2024
6 checks passed
@micszo micszo deleted the ibx-8422 branch July 10, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@alongosz alongosz alongosz approved these changes

@webhdx webhdx webhdx approved these changes

@mnocon mnocon mnocon approved these changes

@konradoboza konradoboza konradoboza approved these changes

@ibexa-yuna ibexa-yuna Awaiting requested review from ibexa-yuna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@micszo @adamwojs @alongosz @webhdx @mnocon @konradoboza