-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-1696: Implemented Config Resolver & service container parameters rebranding #31
Conversation
8cba888
to
cb57dba
Compare
Still draft, but @Nattfarinn @ViniTou any remarks about mapping of config resolver namespaces and parameters (2 map files)? |
cb57dba
to
7dc5386
Compare
7dc5386
to
ab1a917
Compare
|
||
return [ | ||
'ezsettings' => 'ibexa.site_access.config', | ||
'ezrecommendation' => 'ibexa.personalization.site_access.config', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I am against separate namespace just for personalization, unless this is temporary because of the overlay of two PRs.
@ciastektk @alongosz
if anything it should be ibexa.site_access.config.personalization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I am against separate namespace just for personalization, unless this is temporary because of the overlay of two PRs.
if anything it should be ibexa.site_access.config.personalization
@ViniTou I think @ciastektk is gonna merge it into one. On the side note - it cannot be ibexa.site_access.config.personalization
because it's reserved for: ibexa.site_access.config.<scope>
and might cause a conflict when someone decides to create personalization
Site Access.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will merge both configurations into one. Most of the parameters will follow the pattern: ibexa.site_access.config.<scope>.personalization
Rebranding has been finalized without a need for this. Closing as obsolete. |
v4.0.1
This PR implements Config Resolver & service container parameters rebranding add-on to
ibexa:rebranding
command.