Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-1696: Implemented Config Resolver & service container parameters rebranding #31

Closed
wants to merge 8 commits into from

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Jan 31, 2022

Question Answer
JIRA issue IBX-1696
Type feature
Target Ibexa version v4.0.1
BC breaks no

This PR implements Config Resolver & service container parameters rebranding add-on to ibexa:rebranding command.

  • BC layer,
  • Created service container parameters map
  • Created Config Resolver namespaces map
  • Implemented Config Resolver & service container parameters rebranding

@alongosz alongosz force-pushed the ibx-1696-container-parameters-rebranding branch from 8cba888 to cb57dba Compare January 31, 2022 04:17
@alongosz
Copy link
Member Author

alongosz commented Jan 31, 2022

Still draft, but @Nattfarinn @ViniTou any remarks about mapping of config resolver namespaces and parameters (2 map files)?
@ciastektk included ezrecommendation config resolver namespace in the BC map.


return [
'ezsettings' => 'ibexa.site_access.config',
'ezrecommendation' => 'ibexa.personalization.site_access.config',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I am against separate namespace just for personalization, unless this is temporary because of the overlay of two PRs.
@ciastektk @alongosz

if anything it should be ibexa.site_access.config.personalization

Copy link
Member Author

@alongosz alongosz Feb 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I am against separate namespace just for personalization, unless this is temporary because of the overlay of two PRs.
if anything it should be ibexa.site_access.config.personalization

@ViniTou I think @ciastektk is gonna merge it into one. On the side note - it cannot be ibexa.site_access.config.personalization because it's reserved for: ibexa.site_access.config.<scope> and might cause a conflict when someone decides to create personalization Site Access.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will merge both configurations into one. Most of the parameters will follow the pattern: ibexa.site_access.config.<scope>.personalization

@alongosz alongosz marked this pull request as draft February 4, 2022 14:23
@alongosz
Copy link
Member Author

Rebranding has been finalized without a need for this. Closing as obsolete.

@alongosz alongosz closed this Jul 15, 2022
@alongosz alongosz deleted the ibx-1696-container-parameters-rebranding branch July 15, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants