IBX-6211: Added product edit route to EDIT_VIEWS const #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
reviewed
Jul 21, 2023
webhdx
approved these changes
Jul 21, 2023
|
@konradoboza The error is independent of the PR, but I push a fix |
konradoboza
approved these changes
Jul 21, 2023
mateuszdebinski
force-pushed
the
IBX-6211_ezdate_incorrect_pim
branch
from
c066d75 to
f639d99
Compare
|
Summoning @mnocon to look if the Behat-related changes are ok. ;) |
mnocon
approved these changes
Jul 21, 2023
mateuszdebinski
force-pushed
the
IBX-6211_ezdate_incorrect_pim
branch
from
f639d99 to
92a6096
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
adamwojs
requested changes
Jul 24, 2023
| 'ibexa.content.translate', | ||
| 'ibexa.content.translate_with_location', | ||
| 'ibexa.user.update', | ||
| 'ibexa.product_catalog.product.edit', |
There was a problem hiding this comment.
ibexa/content-forms shouldn't refer to symbols defined in ibexa/product-catalog.
|
As this solution is not acceptable, I am closing this ticket and a new one will be opened in ibexa/product-catalog. I will also create a new PR for the changes to the Behat tests that this PR was supposed to make |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://issues.ibexa.co/browse/IBX-6211
The problem was not saving the date, but the fact that input always had data-action-type set to create, this change will allow to recognize whether we are editing or creating content