Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7502: Moved Image asset file validation to field type definition #61

Merged
merged 1 commit into from
Jan 16, 2024
Merged

IBX-7502: Moved Image asset file validation to field type definition #61

merged 1 commit into from
Jan 16, 2024

Conversation

ciastektk
Copy link
Contributor

@ciastektk ciastektk commented Jan 10, 2024 •
edited
Loading

Question Answer
JIRA issue IBX-7502
Type bug
Target Ibexa version v4.6
BC breaks no

Moved file size validation to image asset field type definition: ibexa/core#320

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping for example @ibexa/php-dev for back-end changes and/or @ibexa/javascript-dev for
    front-end changes).

@ciastektk ciastektk added the Bug Something isn't working label Jan 10, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 10, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ciastektk ciastektk mentioned this pull request Jan 10, 2024
Merged
6 tasks
@ciastektk ciastektk requested a review from a team January 10, 2024 11:19
@konradoboza konradoboza requested a review from a team January 15, 2024 08:13
@micszo micszo self-assigned this Jan 15, 2024
@micszo micszo mentioned this pull request Jan 15, 2024
Closed
@micszo micszo removed their assignment Jan 16, 2024
@webhdx webhdx merged commit 49c466c into main Jan 16, 2024
15 checks passed
@webhdx webhdx deleted the ibx-7502-moved-file-validation-to-image-asset-field-type branch January 16, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micszo micszo micszo approved these changes

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@Nattfarinn Nattfarinn

@webhdx webhdx

@konradoboza konradoboza

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ciastektk @micszo @ViniTou @konradoboza @Nattfarinn @webhdx