Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-105: Added automatic release creation on tag push #7

Merged
merged 1 commit into from
Apr 1, 2021
Merged

IBX-105: Added automatic release creation on tag push #7

merged 1 commit into from
Apr 1, 2021

Conversation

ibexa-yuna
Copy link
Contributor

Question Answer
JIRA issue IBX-105
Type improvement
Target Ibexa version v3.3
BC breaks no
Doc needed no

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Checked that target branch is set correctly.
  • Asked for a review (ping @ibexa/engineering).

@ibexa-yuna ibexa-yuna requested review from webhdx and a team April 1, 2021 07:29
Steveb-p
Steveb-p approved these changes Apr 1, 2021
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

.github/workflows/release_tag.yml Outdated Show resolved Hide resolved
@Steveb-p Steveb-p requested a review from a team April 1, 2021 07:57
adamwojs
adamwojs reviewed Apr 1, 2021
View reviewed changes
.github/workflows/release_tag.yml
Comment on lines +52 to +53
FILE1=$(mktemp)
FILE2=$(mktemp)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any change to name it more meaningful?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no need as those are just technical files.

@ibexa-yuna ibexa-yuna merged commit cca688a into master Apr 1, 2021
@ibexa-yuna ibexa-yuna deleted the feature/IBX-105 branch April 1, 2021 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@webhdx webhdx Awaiting requested review from webhdx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibexa-yuna @adamwojs @Steveb-p