Replaced usages of magic getters with strict ones relevant to the issue

src/lib/MVC/Symfony/SiteAccess/Router.php

@@ -130,19 +130,20 @@ public function match(SimplifiedRequest $request)
         }
 
         // Request header always have precedence
-        // Note: request headers are always in lower cased.
-        if (!empty($request->headers['x-siteaccess'])) {
-            $siteaccessName = $request->headers['x-siteaccess'][0];
-            if (!$this->siteAccessProvider->isDefined($siteaccessName)) {
+        // Note: request headers are always lower case.
+        $xSiteAccess = $request->getHeader('x-siteaccess');
+        if (!empty($xSiteAccess) && is_array($xSiteAccess)) {
+            $siteAccessName = $xSiteAccess[0];
+            if (!$this->siteAccessProvider->isDefined($siteAccessName)) {
                 throw new InvalidSiteAccessException(
-                    $siteaccessName,
+                    $siteAccessName,
                     $this->siteAccessProvider,
                     'X-Siteaccess request header',
                     $this->debug
                 );
             }
 
-            $this->siteAccess = $this->siteAccessProvider->getSiteAccess($siteaccessName);
+            $this->siteAccess = $this->siteAccessProvider->getSiteAccess($siteAccessName);
             $this->siteAccess->matchingType = self::HEADER_SA_MATCHING_TYPE;
 
             return $this->siteAccess;

src/lib/Repository/ContentService.php

@@ -253,7 +253,7 @@ public function loadContentInfoByRemoteId(string $remoteId): ContentInfo
      */
     public function loadVersionInfo(ContentInfo $contentInfo, ?int $versionNo = null): APIVersionInfo
     {
-        return $this->loadVersionInfoById($contentInfo->id, $versionNo);
+        return $this->loadVersionInfoById($contentInfo->getId(), $versionNo);
     }
 
     /**
@@ -2121,9 +2121,7 @@ public function countReverseRelations(ContentInfo $contentInfo): int
             return 0;
         }
 
-        return $this->persistenceHandler->contentHandler()->countReverseRelations(
-            $contentInfo->id
-        );
+        return $this->persistenceHandler->contentHandler()->countReverseRelations($contentInfo->getId());
     }
 
     /**

src/lib/Repository/Mapper/ContentDomainMapper.php

@@ -237,14 +237,14 @@ public function buildDomainFields(
         }
 
         $fieldDefinitionsMap = [];
-        foreach ($contentType->fieldDefinitions as $fieldDefinition) {
-            $fieldDefinitionsMap[$fieldDefinition->id] = $fieldDefinition;
+        foreach ($contentType->getFieldDefinitions() as $fieldDefinition) {
+            $fieldDefinitionsMap[$fieldDefinition->getId()] = $fieldDefinition;
         }
 
         $fieldInFilterLanguagesMap = [];
         if (!empty($prioritizedLanguages) && $alwaysAvailableLanguage !== null) {
             foreach ($spiFields as $spiField) {
-                if (in_array($spiField->languageCode, $prioritizedLanguages)) {
+                if (in_array($spiField->languageCode, $prioritizedLanguages, true)) {
                     $fieldInFilterLanguagesMap[$spiField->fieldDefinitionId] = true;
                 }
             }
@@ -259,7 +259,7 @@ public function buildDomainFields(
 
             $fieldDefinition = $fieldDefinitionsMap[$spiField->fieldDefinitionId];
 
-            if (!empty($prioritizedLanguages) && !in_array($spiField->languageCode, $prioritizedLanguages)) {
+            if (!empty($prioritizedLanguages) && !in_array($spiField->languageCode, $prioritizedLanguages, true)) {
                 // If filtering is enabled we ignore fields in other languages then $prioritizedLanguages, if:
                 if ($alwaysAvailableLanguage === null) {
                     // Ignore field if we don't have $alwaysAvailableLanguageCode fallback
@@ -273,13 +273,13 @@ public function buildDomainFields(
                 }
             }
 
-            $fields[$fieldDefinition->position][] = new Field(
+            $fields[$fieldDefinition->getPosition()][] = new Field(
                 [
                     'id' => $spiField->id,
                     'value' => $this->fieldTypeRegistry->getFieldType($spiField->type)
                         ->fromPersistenceValue($spiField->value),
                     'languageCode' => $spiField->languageCode,
-                    'fieldDefIdentifier' => $fieldDefinition->identifier,
+                    'fieldDefIdentifier' => $fieldDefinition->getIdentifier(),
                     'fieldTypeIdentifier' => $spiField->type,
                 ]
             );
@@ -536,12 +536,13 @@ private function buildRootLocation(SPILocation $spiLocation): APILocation
             'alwaysAvailable' => 1,
             'remoteId' => null,
             'mainLanguageCode' => 'eng-GB',
+            'isHidden' => false,
         ]);
 
         $content = new Content([
             'versionInfo' => new VersionInfo([
                 'names' => [
-                    $contentInfo->mainLanguageCode => $contentInfo->name,
+                    $contentInfo->getMainLanguageCode() => $contentInfo->getName(),
                 ],
                 'contentInfo' => $contentInfo,
                 'versionNo' => $contentInfo->currentVersionNo,
@@ -571,7 +572,7 @@ private function mapLocation(
                 'contentInfo' => $contentInfo,
                 'id' => $spiLocation->id,
                 'priority' => $spiLocation->priority,
-                'hidden' => $spiLocation->hidden || $contentInfo->isHidden,
+                'hidden' => $spiLocation->hidden || $contentInfo->isHidden(),
                 'invisible' => $spiLocation->invisible,
                 'explicitlyHidden' => $spiLocation->hidden,
                 'remoteId' => $spiLocation->remoteId,

src/lib/Repository/Mapper/ContentLocationMapper/DecoratedLocationService.php

@@ -123,8 +123,8 @@ private function setLocationMappings(iterable $locationList): void
     {
         foreach ($locationList as $location) {
             $this->contentLocationMapper->setMapping(
-                $location->id,
-                $location->contentId
+                $location->getId(),
+                $location->getContentId()
             );
         }
     }

src/lib/Repository/Strategy/ContentThumbnail/FirstMatchingFieldStrategy.php

@@ -37,18 +37,18 @@ public function getThumbnail(ContentType $contentType, array $fields, ?VersionIn
         $fieldDefinitions = $contentType->getFieldDefinitions();
 
         foreach ($fieldDefinitions as $fieldDefinition) {
-            $field = $this->getFieldByIdentifier($fieldDefinition->identifier, $fields);
+            $field = $this->getFieldByIdentifier($fieldDefinition->getIdentifier(), $fields);
 
             if ($field === null) {
                 continue;
             }
 
-            $fieldType = $this->fieldTypeService->getFieldType($fieldDefinition->fieldTypeIdentifier);
+            $fieldType = $this->fieldTypeService->getFieldType($fieldDefinition->getFieldTypeIdentifier());
 
             if (
-                $fieldDefinition->isThumbnail
-                && $this->contentFieldStrategy->hasStrategy($field->fieldTypeIdentifier)
-                && !$fieldType->isEmptyValue($field->value)
+                $fieldDefinition->isThumbnail()
+                && $this->contentFieldStrategy->hasStrategy($field->getFieldTypeIdentifier())
+                && !$fieldType->isEmptyValue($field->getValue())
             ) {
                 return $this->contentFieldStrategy->getThumbnail($field, $versionInfo);
             }
@@ -61,7 +61,7 @@ private function getFieldByIdentifier(string $identifier, array $fields): ?Field
     {
         /** @var \Ibexa\Contracts\Core\Repository\Values\Content\Field $field */
         foreach ($fields as $field) {
-            if ($field->fieldDefIdentifier === $identifier) {
+            if ($field->getFieldDefinitionIdentifier() === $identifier) {
                 return $field;
             }
         }

src/lib/Repository/UserService.php

@@ -479,12 +479,12 @@ public function loadUser(int $userId, array $prioritizedLanguages = []): APIUser
         $content = $this->repository->getContentService()->internalLoadContentById($userId, $prioritizedLanguages);
         // Get spiUser value from Field Value
         foreach ($content->getFields() as $field) {
-            if (!$field->value instanceof UserValue) {
+            $fieldValue = $field->getValue();
+            if (!$fieldValue instanceof UserValue) {
                 continue;
             }
 
-            /** @var \Ibexa\Core\FieldType\User\Value $value */
-            $value = $field->value;
+            $value = $fieldValue;
             $spiUser = new SPIUser();
             $spiUser->id = $value->contentId;
             $spiUser->login = $value->login;

src/lib/Repository/Values/Content/Content.php

@@ -75,9 +75,11 @@ public function __construct(array $data = [])
         $this->prioritizedFieldLanguageCode = $data['prioritizedFieldLanguageCode'] ?? null;
 
         foreach ($this->internalFields as $field) {
-            $this->fieldDefinitionTranslationMap[$field->fieldDefIdentifier][$field->languageCode] = $field;
+            $languageCode = $field->getLanguageCode();
+            $fieldDefinitionIdentifier = $field->getFieldDefinitionIdentifier();
+            $this->fieldDefinitionTranslationMap[$fieldDefinitionIdentifier][$languageCode] = $field;
             // kept for BC due to property-read magic getter
-            $this->fields[$field->fieldDefIdentifier][$field->languageCode] = $field->value;
+            $this->fields[$fieldDefinitionIdentifier][$languageCode] = $field->getValue();
         }
     }
 
@@ -182,10 +184,10 @@ public function __get($property)
     {
         switch ($property) {
             case 'id':
-                return $this->versionInfo->getContentInfo()->id;
+                return $this->getVersionInfo()->getContentInfo()->getId();
 
             case 'contentInfo':
-                return $this->versionInfo->getContentInfo();
+                return $this->getVersionInfo()->getContentInfo();
 
             case 'thumbnail':
                 return $this->getThumbnail();

src/lib/Repository/Values/Content/Location.php

@@ -73,7 +73,7 @@ public function __get($property)
     {
         switch ($property) {
             case 'contentId':
-                return $this->contentInfo->id;
+                return $this->getContentInfo()->getId();
             case 'path':
                 if ($this->path !== null) {
                     return $this->path;

src/lib/Repository/Values/ContentType/FieldDefinitionCollection.php

@@ -34,7 +34,7 @@ public function __construct(iterable $fieldDefinitions = [])
 
         foreach ($fieldDefinitions as $fieldDefinition) {
             $this->fieldDefinitions[] = $fieldDefinition;
-            $this->fieldDefinitionsByIdentifier[$fieldDefinition->identifier] = $fieldDefinition;
+            $this->fieldDefinitionsByIdentifier[$fieldDefinition->getIdentifier()] = $fieldDefinition;
         }
     }
 
@@ -162,7 +162,7 @@ public function toArray(): array
     private function getIsTypePredicate(string $fieldTypeIdentifier): Closure
     {
         return static function (FieldDefinition $fieldDefinition) use ($fieldTypeIdentifier) {
-            return $fieldDefinition->fieldTypeIdentifier === $fieldTypeIdentifier;
+            return $fieldDefinition->getFieldTypeIdentifier() === $fieldTypeIdentifier;
         };
     }
 

src/lib/Repository/Values/User/User.php

@@ -130,7 +130,7 @@ public function __get($property)
                 return $this->getVersionInfo()->getContentInfo();
 
             case 'id':
-                return $this->getVersionInfo()->getContentInfo()->id;
+                return $this->getVersionInfo()->getContentInfo()->getId();
 
             case 'versionInfo':
                 return $this->getVersionInfo();