IBX-7364: Ensured independent property assignment in setPreviewActive (…

…#323) For more details see https://issues.ibexa.co/browse/IBX-7364 and #323 Key changes: * Ensured independent property assignment in setPreviewActive method by using clone
ibexa · Feb 12, 2024 · 8f01648 · 8f01648
1 parent a06df7b
commit 8f01648
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/lib/Helper/ContentPreviewHelper.php b/src/lib/Helper/ContentPreviewHelper.php
@@ -98,6 +98,7 @@ public function isPreviewActive()
     public function setPreviewActive($previewActive)
     {
         $this->previewActive = (bool)$previewActive;
+        $this->originalSiteAccess = clone $this->originalSiteAccess;
     }
 
     /**

diff --git a/tests/lib/Helper/ContentPreviewHelperTest.php b/tests/lib/Helper/ContentPreviewHelperTest.php
@@ -78,11 +78,16 @@ public function testRestoreConfigScope()
 
     public function testPreviewActive()
     {
+        $originalSiteAccess = new SiteAccess('foo', 'bar');
+        $this->previewHelper->setSiteAccess($originalSiteAccess);
+
         $this->assertFalse($this->previewHelper->isPreviewActive());
         $this->previewHelper->setPreviewActive(true);
         $this->assertTrue($this->previewHelper->isPreviewActive());
         $this->previewHelper->setPreviewActive(false);
         $this->assertFalse($this->previewHelper->isPreviewActive());
+
+        self::assertNotSame($originalSiteAccess, $this->previewHelper->getOriginalSiteAccess());
     }
 
     public function testPreviewedContent()