Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4046: Allow custom header name to be used in reverse proxy env #165

Merged
merged 4 commits into from
Oct 28, 2022
Merged

IBX-4046: Allow custom header name to be used in reverse proxy env #165

merged 4 commits into from
Oct 28, 2022

Conversation

Nattfarinn
Copy link
Contributor

@Nattfarinn Nattfarinn commented Oct 26, 2022 •
edited
Loading

Question Answer
JIRA issue IBX-4046
Type feature
Target Ibexa version v4.3
BC breaks yes

trusted_header_client_ip_name parameter to be used as a mapping between custom header and X_FORWARDED_FOR header. It requires dev to configure trusted_proxies with a proper proxy server IP to be allowed to use trusted headers in a first place (remainder in recipes: ibexa/recipes-dev@404a899 ).

It also covers Platform.sh X-Client-Ip header in a transparent way (dev still needs trusted_proxies to be set). Custom header still has priority over Platform.sh header (in case when custom header is used within P.sh env).

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@Nattfarinn Nattfarinn requested review from Steveb-p, alongosz and a team October 26, 2022 15:54
alongosz
alongosz approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one remark:

src/bundle/Core/Resources/config/default_settings.yml Outdated Show resolved Hide resolved
@alongosz alongosz requested a review from a team October 26, 2022 16:56
@konradoboza konradoboza requested a review from a team October 27, 2022 06:37
@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2022 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alongosz
Copy link
Member

CI issue is random, merging.

@alongosz alongosz merged commit 7a117a7 into main Oct 28, 2022
@alongosz alongosz deleted the ibx-4046-bot-prevention branch October 28, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@ciastektk ciastektk ciastektk approved these changes

@mnocon mnocon mnocon approved these changes

@konradoboza konradoboza konradoboza approved these changes

@Steveb-p Steveb-p Awaiting requested review from Steveb-p

Assignees

@adamwojs adamwojs

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@alongosz alongosz

@ciastektk ciastektk

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Nattfarinn @alongosz @Steveb-p @ciastektk @mnocon @konradoboza @adamwojs @mikadamczyk