Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4598: Added support for generating urls for content wrappers in ibexa_url/ibexa_path #181

Merged
merged 3 commits into from
Sep 3, 2023
Merged

IBX-4598: Added support for generating urls for content wrappers in ibexa_url/ibexa_path #181

merged 3 commits into from
Sep 3, 2023

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Dec 17, 2022 •
edited
Loading

Question Answer
JIRA issue IBX-4598
Type feature
Target Ibexa version v4.6
BC breaks no

Added support for generating urls for content wrappers (e.g. Taxonomy Entry, Product) in ibexa_url/ibexa_path.

{# content_wrapper implements \Ibexa\Contracts\Core\Repository\Values\Content\ContentAware #}
{{ ibexa_url(content_wrapper) }}

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@sonarcloud
Copy link

sonarcloud bot commented Dec 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adamwojs adamwojs requested review from alongosz and a team August 27, 2023 12:40
@sonarcloud
Copy link

sonarcloud bot commented Aug 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@webhdx webhdx added Feature New feature request Ready for review labels Aug 30, 2023
@alongosz alongosz requested a review from a team August 30, 2023 08:09
@adamwojs adamwojs merged commit d79cd43 into main Sep 3, 2023
23 checks passed
@adamwojs adamwojs deleted the ibx_4598 branch September 3, 2023 07:29
ciastektk pushed a commit that referenced this pull request Sep 4, 2023
@adamwojs @ciastektk
IBX-4598: Added support for generating urls for content wrappers in i…
8a7b1e9 
…bexa_url/ibexa_path (#181)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@ciastektk ciastektk ciastektk approved these changes

@webhdx webhdx webhdx approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@adamwojs adamwojs

@kisztof kisztof

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@alongosz alongosz

@ciastektk ciastektk

Labels
Feature New feature request Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@adamwojs @alongosz @ciastektk @webhdx @konradoboza @kisztof @mikadamczyk @Steveb-p