Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4452: Added missing translation for content #186

Merged
merged 1 commit into from
Dec 23, 2022
Merged

IBX-4452: Added missing translation for content #186

merged 1 commit into from
Dec 23, 2022

Conversation

kisztof
Copy link
Contributor

@kisztof kisztof commented Dec 22, 2022 •
edited by alongosz
Loading

Question Answer
JIRA issue IBX-4452
Type improvement
Target Ibexa version v4.4
BC breaks no

This PR adds missing translation definition and also fixed sonar errors.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@kisztof kisztof requested a review from a team December 22, 2022 15:11
@kisztof kisztof marked this pull request as ready for review December 22, 2022 15:11
@alongosz
Copy link
Member

@kisztof Sonar analysis is failing here

@kisztof kisztof force-pushed the ibx-4452-deprecate-translation-extractors branch from e7d993b to 1148191 Compare December 23, 2022 08:24
@sonarcloud
Copy link

sonarcloud bot commented Dec 23, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
100.0% 100.0% Duplication

@kisztof kisztof requested a review from a team December 23, 2022 08:36
@alongosz alongosz merged commit b2c0601 into main Dec 23, 2022
@alongosz alongosz deleted the ibx-4452-deprecate-translation-extractors branch December 23, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@alongosz alongosz alongosz approved these changes

@webhdx webhdx webhdx approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@adamwojs adamwojs

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@alongosz alongosz

@ciastektk ciastektk

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kisztof @alongosz @adamwojs @webhdx @konradoboza @mikadamczyk @Steveb-p @ciastektk