Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-4923: Fixed schema for welcome page #197

Closed
wants to merge 1 commit into from

Conversation

ciastektk
Copy link
Contributor

Question Answer
JIRA issue IBX-4923
Type improvement
Target Ibexa version v4.4
BC breaks no

Product name should be unified across all editions.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@@ -85,7 +85,7 @@ VALUES (1031216928, 14, 1, 1033922106, 14, 'Content'),
(1032009743, 14, 3, 1033922120, 14, 'Media');

INSERT INTO `ezcontentobject` (`contentclass_id`, `current_version`, `id`, `initial_language_id`, `language_mask`, `modified`, `name`, `owner_id`, `published`, `remote_id`, `section_id`, `status`)
VALUES (1,9,1,2,3,1448889046,'Ibexa Platform',14,1448889046,'9459d3c29e15006e45197295722c7ade',1,1),
VALUES (1,9,1,2,3,1448889046,'Ibexa Digital Experience Platform',14,1448889046,'9459d3c29e15006e45197295722c7ade',1,1),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should say Ibexa OSS or just Ibexa. It's not Ibexa DXP.

@ciastektk
Copy link
Contributor Author

After internal discussion we decided not to rename content and close this PR.

@ciastektk ciastektk closed this Jan 27, 2023
@ciastektk ciastektk deleted the ibx-4923-fixed-schema-for-welcome-page branch January 27, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants