Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5314: Implemented token storage #217

Merged
merged 46 commits into from
Apr 5, 2023
Merged

IBX-5314: Implemented token storage #217

merged 46 commits into from
Apr 5, 2023

Conversation

ciastektk
Copy link
Contributor

@ciastektk ciastektk commented Mar 15, 2023 •
edited by alongosz
Loading

Question Answer
JIRA issue IBX-5314
Type feature
Target Ibexa version v4.5
BC breaks no

This PR implements tokens management for use in e.g.: Personalization authentication.

Implemented layers:

  • Gateway
  • Handler
  • Events
  • Service

There is also added WebSafeGenerator as an implementation of TokenGeneratorIntrface for providing generated tokens.

To be done:

  • Add tests coverage

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@ciastektk ciastektk marked this pull request as ready for review March 16, 2023 07:28
@ciastektk ciastektk requested a review from a team March 16, 2023 07:29
alongosz
alongosz requested changes Mar 16, 2023
View reviewed changes
src/bundle/Core/Resources/config/storage/legacy/schema.yaml Outdated Show resolved Hide resolved
src/bundle/Core/Resources/config/storage/legacy/schema.yaml Outdated Show resolved Hide resolved
src/bundle/Core/Resources/config/storage/legacy/schema.yaml Outdated Show resolved Hide resolved
src/contracts/Persistence/Token/CreateStruct.php Show resolved Hide resolved
src/contracts/Persistence/Token/Handler.php Show resolved Hide resolved
src/contracts/Repository/Events/Token/BeforeGetTokenEvent.php Outdated Show resolved Hide resolved
src/contracts/Repository/Events/Token/BeforeGenerateTokenEvent.php Outdated Show resolved Hide resolved
src/contracts/Repository/Events/Token/BeforeCheckTokenEvent.php Outdated Show resolved Hide resolved
src/contracts/Persistence/Token/Token.php Show resolved Hide resolved
src/lib/Persistence/Legacy/Token/Handler.php Outdated Show resolved Hide resolved
@alongosz alongosz requested a review from a team March 16, 2023 11:22
@ciastektk ciastektk requested a review from Steveb-p April 3, 2023 11:35
Steveb-p
Steveb-p approved these changes Apr 3, 2023
View reviewed changes
tests/lib/Token/WebSafeGeneratorTest.php Outdated Show resolved Hide resolved
ciastektk and others added 2 commits April 3, 2023 16:20
@ciastektk @Steveb-p
Update tests/lib/Token/RandomBytesGeneratorTest.php
37fb306 
Co-authored-by: Paweł Niedzielski <pawel.niedzielski@ibexa.co>
@ciastektk @Steveb-p
Update tests/lib/Token/WebSafeGeneratorTest.php
19d232d 
Co-authored-by: Paweł Niedzielski <pawel.niedzielski@ibexa.co>
@ciastektk ciastektk requested review from Steveb-p and a team April 3, 2023 14:37
@ciastektk ciastektk force-pushed the ibx-5314-implemented-token-storage branch from 8b45541 to 32705b8 Compare April 4, 2023 10:25
@ciastektk ciastektk force-pushed the ibx-5314-implemented-token-storage branch from 32705b8 to 4e5d793 Compare April 4, 2023 10:32
@alongosz alongosz requested a review from a team April 4, 2023 10:46
@alongosz alongosz added Feature New feature request Ready for review labels Apr 4, 2023
@Steveb-p Steveb-p requested a review from a team April 4, 2023 10:47
@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alongosz
Copy link
Member

alongosz commented Apr 5, 2023

This is self-contained PHP API, covered with integration tests. CI green status should be enough to make it mergable.
Due to time constraints merging to unblock https://github.com/ibexa/personalization/pull/238.

@alongosz alongosz merged commit 8f1a3c3 into main Apr 5, 2023
@alongosz alongosz deleted the ibx-5314-implemented-token-storage branch April 5, 2023 07:58
@mnocon mnocon mentioned this pull request May 5, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@alongosz alongosz alongosz approved these changes

Assignees

@adamwojs adamwojs

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@alongosz alongosz

@ciastektk ciastektk

Labels
Feature New feature request Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ciastektk @alongosz @Steveb-p @adamwojs @mikadamczyk @Nattfarinn